Skip to content

Comments

kind-lang: init at 0.1.0.0-unstable-2024-12-09#371934

Merged
FliegendeWurst merged 2 commits intoNixOS:masterfrom
joaoyymoreira:kind-lang
Mar 19, 2025
Merged

kind-lang: init at 0.1.0.0-unstable-2024-12-09#371934
FliegendeWurst merged 2 commits intoNixOS:masterfrom
joaoyymoreira:kind-lang

Conversation

@joaoymoreira
Copy link
Contributor

@joaoymoreira joaoymoreira commented Jan 7, 2025 •
edited
Loading

Add Kind proof language https://github.com/HigherOrderCO/kind

Successfully tested with https://github.com/HigherOrderCO/kindbook

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jan 7, 2025
@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jan 7, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 7, 2025
@joaoymoreira joaoymoreira marked this pull request as ready for review January 7, 2025 22:54
@joaoymoreira joaoymoreira marked this pull request as draft January 18, 2025 13:50
@joaoymoreira joaoymoreira force-pushed the kind-lang branch 2 times, most recently from 84a1080 to ecf7652 Compare January 21, 2025 20:55
@joaoymoreira joaoymoreira marked this pull request as ready for review January 21, 2025 20:57
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Jan 21, 2025
@joaoymoreira
Copy link
Contributor Author

joaoymoreira commented Jan 22, 2025

I forced pushed just to make the code more future-adaptable for an auto update script.

@nixos-discourse
Copy link

nixos-discourse commented Jan 25, 2025

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5134

@FliegendeWurst FliegendeWurst added the 8.has: package (new) This PR adds a new package label Mar 11, 2025
@joaoymoreira joaoymoreira changed the title kind-lang: init at unstable-2024-12-09 kind-lang: init at 0.1.0.0-unstable-2024-12-09 Mar 17, 2025
FliegendeWurst
FliegendeWurst reviewed Mar 17, 2025
View reviewed changes
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Mar 17, 2025
@ofborg ofborg bot removed the ofborg-internal-error Ofborg encountered an error label Mar 18, 2025
@FliegendeWurst
Copy link
Member

FliegendeWurst commented Mar 18, 2025

Restarted Eval job. Seems like Github still randomly fails some action runs.

@joaoymoreira
Copy link
Contributor Author

joaoymoreira commented Mar 18, 2025

Restarted Eval job. Seems like Github still randomly fails some action runs.

Seems like all checks have passed. If you also could have a look at #375700 (depends on the maintainers: add joaomoreira commit of this PR)

@GaetanLepage

This comment was marked as outdated.

Sign in to view
GaetanLepage
GaetanLepage requested changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joaoymoreira can you please address my former comments?
Otherwise, the package seems quite fine! Good job :)

@nixos-discourse
Copy link

nixos-discourse commented Mar 18, 2025

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2308

@joaoymoreira
kind-lang: init at 0.1.0.0-unstable-2024-12-09
0d9c02c 
Co-authored-by: maralorn <mail@maralorn.de>
Co-authored-by: Lukas Epple <sternenseemann@systemli.org>
Co-authored-by: Lin Jian <me@linj.tech>
Co-authored-by: Emily <nixpkgs@emily.moe>
Co-authored-by: Bryan Richter <b@chreekat.net>
Co-authored-by: Niklas Korz <niklas@niklaskorz.de>
Co-authored-by: Ilya K. <me@0upti.me>
Co-authored-by: Alexandre Esteves <alexandre.fmp.esteves@gmail.com>
Co-authored-by: Arne Keller <arne.keller@posteo.de>
Co-authored-by: Gaetan Lepage <gaetan@glepage.com>

REFERENCES
- pkgs/by-name/ni/nixfmt-rfc-style
- https://github.com/nixos/cabal2nix
@GaetanLepage
Copy link
Contributor

GaetanLepage commented Mar 19, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371934

x86_64-linux

✅ 1 package built:
  • kind-lang

aarch64-linux

✅ 1 package built:
  • kind-lang

x86_64-darwin

✅ 1 package built:
  • kind-lang

aarch64-darwin

✅ 1 package built:
  • kind-lang

@FliegendeWurst FliegendeWurst merged commit 7f42547 into NixOS:master Mar 19, 2025
27 of 29 checks passed
@FliegendeWurst
Copy link
Member

FliegendeWurst commented Mar 19, 2025

Now that we package the new kind version, is there still a use for the older kind2? pkgs/development/compilers/kind2/default.nix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FliegendeWurst FliegendeWurst FliegendeWurst left review comments

@GaetanLepage GaetanLepage GaetanLepage approved these changes

Assignees

No one assigned

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joaoymoreira @nixos-discourse @FliegendeWurst @GaetanLepage @NixOSInfra